Support

Admin Tools

#9887 ATP 205 joomla instances within html notes

Posted in ‘Admin Tools for Joomla! 4 & 5’
This is a public ticket

Everybody will be able to see its contents. Do not include usernames, passwords or any other sensitive information.

Environment Information

Joomla! version
n/a
PHP version
n/a
Admin Tools version
n/a

Latest post by nicholas on Tuesday, 31 May 2011 10:12 CDT

slaes
hey nico,

just letting you know (incase you dont already) that atp 205 no longer removes joomla output within html notes

nicholas
Akeeba Staff
Manager
This is intentional. We can either have a rule to remove all HTML comments (preferably using Tidy) or you can use reReplacer by NoNumber to accomplish the same thing. Which option do you think is better?

Nicholas K. Dionysopoulos

Lead Developer and Director

πŸ‡¬πŸ‡·Greek: native πŸ‡¬πŸ‡§English: excellent πŸ‡«πŸ‡·French: basic β€’ πŸ• My time zone is Europe / Athens
Please keep in mind my timezone and cultural differences when reading my replies. Thank you!

slaes
personally i think tidy would be better. what were you doing with previous versions of atp, such as 112 where it was removing just joomla from within
out of curiosity do you know of any way to remove all /* notes from all output, server side?

on another note, your site login from within deep links still seems to be having some js issues.

things have been unusually quiet for a while lately, you must be enjoying a holiday? :)

slaes
from the atp forum anyway

nicholas
Akeeba Staff
Manager
I prefer Tidy as well. My only concern is the processing overhead, especially taking into account that Joomla! 1.5 does no caching for logged in users. I plan on implementing that feature when Joomla! hits 1.8 and we all have to migrate to the new system with a much more improved page caching (therefore mitigating the Tidy overhead).

I assume that you want to remove Javascript comments. That is impossible. Javascript is a strange beast. You can't do that with regular expressions, you need a tokenizing parser to do that and that is impossible to write in PHP. It's also impossible to run it per page load, as the performance impact is extremely high.

I know about the login... The problem is mooTools (surprise!). I need mooTools 1.2 for Akeeba Subscriptions to run. K2 uses 1.11 and always loads its Javascript. I am just being patient at the moment, as K2 2.5 drops mooTools and uses jQuery, which is FAR EASIER to tame - and much less likely to cause incompatibilities.

It's quiet, yes! I think that my efforts with the forum's operation had effect. If you are not a subscriber you can no longer cross-post, you get a huge warning to read the documentation (with links!), you can't reply to your post in less than 8 hours and you can't write on more than 2 threads per week. These restrictions force users to actually read the documentation and, surprise, solve their issues without posting on the forum. As I have already said, unless you force people to read, they won't. If you do force them, they will actually thank you for providing a great troubleshooting guide :)

Nicholas K. Dionysopoulos

Lead Developer and Director

πŸ‡¬πŸ‡·Greek: native πŸ‡¬πŸ‡§English: excellent πŸ‡«πŸ‡·French: basic β€’ πŸ• My time zone is Europe / Athens
Please keep in mind my timezone and cultural differences when reading my replies. Thank you!

slaes

thats funny, ive had my own issue with mootools 1.11 especially with bind functions, im over it and have to resort to things like the below, hmmm not ideal. over it man!!

try{delete Function.prototype.bind;}catch(e){}

it might be worth implementing the option for remove all comments, while we wait, im sure those who can handle the overhead will. im sure i have seen significantly more script activity since, who knows, maybe its just me :)

lol, i see, was wondering why things were a little quiet, actually surprised you didnt implement such things sooner. you probably didnt have the time, busy on the forum ;) and hey i only answered repeat things a dozen times lol.

slaes
oh yeah and screw it, im gonna start minifying all css and ja. unless of course you decided your gonna impliment a feature in atp to do so, lol. what do you think?

nicholas
Akeeba Staff
Manager
I've experimented with some techniques. CSS combination and minification works wonders, albeit it takes very long to generate the minified files (good think there's caching involved!). JS minification is impossible due to the need of a tokenizing parser.

And here's the icing on the cake: you do not need JS minification! You can't combine JS files (without screwing the whole lot of pages). So, it's far more efficient to just GZip the JS files, like what .htaccess Maker does.

See my point? ;)

Nicholas K. Dionysopoulos

Lead Developer and Director

πŸ‡¬πŸ‡·Greek: native πŸ‡¬πŸ‡§English: excellent πŸ‡«πŸ‡·French: basic β€’ πŸ• My time zone is Europe / Athens
Please keep in mind my timezone and cultural differences when reading my replies. Thank you!

slaes
indeed i do. i have played with Douglas Crockford's stuff however it certainly not without it's issues, especially when some people insist on producing scripts which store data within comments. I for one find it very annoying.

so any chance you might add function to combine css, minify css, both and also combine js. That would be awesome and would definitely give atp another dimension.

nicholas
Akeeba Staff
Manager
FYI, they are already scheduled for Admin Tools 2.2, as you can see in the ticket tracker (tickets #8 and #9) ;)

Nicholas K. Dionysopoulos

Lead Developer and Director

πŸ‡¬πŸ‡·Greek: native πŸ‡¬πŸ‡§English: excellent πŸ‡«πŸ‡·French: basic β€’ πŸ• My time zone is Europe / Athens
Please keep in mind my timezone and cultural differences when reading my replies. Thank you!

Support Information

Working hours: We are open Monday to Friday, 9am to 7pm Cyprus timezone (EET / EEST). Support is provided by the same developers writing the software, all of which live in Europe. You can still file tickets outside of our working hours, but we cannot respond to them until we're back at the office.

Support policy: We would like to kindly inform you that when using our support you have already agreed to the Support Policy which is part of our Terms of Service. Thank you for your understanding and for helping us help you!