Akeeba Ticket System

Sunday, 01 December 2013 17:29 CST

blaztoma

Hello!

I'm not really sure, but it seems like a bug in postemail plugin. It sends notification to all the managers although i have selected only one to receive notifications.
I had to change this code:

		// Nope! I have to notify a subset. Let's start removing them
		$t_managers = $managers;
		for($i = 0; $i < count($t_managers); $i++)
		{
			if(!in_array($t_managers[$i]->id, $notify))
			{
				unset($managers[$i]);
			}
		}

into this one:

		foreach($managers as $manager)
		{
			if(in_array($manager->id, $notify))
			{
				$xmanagers[]=$manager;
			}
		}

in file postemail.php to make it work as it should. At least it notifies only managers i have selected.

Is this some bug or did i miss something?

Monday, 02 December 2013 08:11 CST

nicholas

I honestly can't see how your code, as posted here, has the effect you claimed it has. The $xmanagers variable is not defined or use anywhere else. As a result, in the end of the method you return the unmodified $managers which contains all of the managers of the category.

In other words, your change is causing the bug you claim it's fixing.

I think you made more changes to that file, otherwise this just doesn't make sense?

Nicholas K. Dionysopoulos

Lead Developer and Director

🇬🇷Greek: native 🇬🇧English: excellent 🇫🇷French: basic • 🕐 My time zone is Europe / Athens
Please keep in mind my timezone and cultural differences when reading my replies. Thank you!

Monday, 02 December 2013 13:06 CST

blaztoma

Thanks for an answer!
I didn't want to provide the bug fix - just to say that unset part somewhat isn't working. I don't know why. Because of this, the plugin sends email to all the managers regardless of what i selected in "notify managers" box.
Regarding my solution - it's an empty array (xmanagers) which i populate with people in $notify list (the $notify list is correct). At the end i return $xmanagers (sorry forgot to copy that line).

Tuesday, 03 December 2013 01:12 CST

nicholas

Ah, OK, now I understand what you mean. I was looking at the code and saw the problem. It has to do with the way PHP handles array variables. My solution is essentially the same as yours, provided that I return the array where I added managers at the end. All right, we've arrived at the identical solution so yes, you are right, that's a bug and your fix is correct.

Nicholas K. Dionysopoulos

Lead Developer and Director

🇬🇷Greek: native 🇬🇧English: excellent 🇫🇷French: basic • 🕐 My time zone is Europe / Athens
Please keep in mind my timezone and cultural differences when reading my replies. Thank you!

Support